docs(interval): more practical example #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pertrai1
force-pushed
the
update-interval-docs-example
branch
2 times, most recently
from
be5d484
to
165b00f
Compare
niklas-wortmann
requested changes
Aug 22, 2018
src/internal/observable/interval.ts
Outdated
| * const numbers = interval(1000); | ||
| * numbers.subscribe(x => console.log(x)); | ||
| * | ||
| * const takeThreeNumbers = numbers.pipe(take(4)); |
There was a problem hiding this comment.
isn't it takeFourNumbers 😄
pertrai1
force-pushed
the
update-interval-docs-example
branch
from
165b00f
to
c63a7c3
Compare
niklas-wortmann
approved these changes
Aug 22, 2018
cartant
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updating the example to add import(s) into the example as is being done in other docs, as well as a cleaner usage.